IOSAD-157 Remove PEPSync.isRunning IOSAD-157
authorDirk Zimmermann <dz@pep.security>
Wed, 20 Nov 2019 09:10:05 +0100
branchIOSAD-157
changeset 1349579234097a35
parent 1348 c59fbbe00a8a
child 1350 9909969de797
IOSAD-157 Remove PEPSync.isRunning
pEpObjCAdapter/PEPSync.m
pEpObjCAdapterFramework/PEPSync.h
pEpObjCTests/PEPSessionTest.m
     1.1 --- a/pEpObjCAdapter/PEPSync.m	Tue Nov 19 17:42:47 2019 +0100
     1.2 +++ b/pEpObjCAdapter/PEPSync.m	Wed Nov 20 09:10:05 2019 +0100
     1.3 @@ -160,7 +160,6 @@
     1.4  
     1.5  - (void)startup
     1.6  {
     1.7 -    self.isRunning = YES;
     1.8      g_isKeySyncEnabled = YES;
     1.9  
    1.10      // Make sure queue is empty when we start.
    1.11 @@ -227,7 +226,6 @@
    1.12          os_log_error(s_logger, "could not create session for starting the sync loop");
    1.13      }
    1.14  
    1.15 -    self.isRunning = NO;
    1.16      g_isKeySyncEnabled = NO;
    1.17  
    1.18      os_log(s_logger, "sync loop finished");
     2.1 --- a/pEpObjCAdapterFramework/PEPSync.h	Tue Nov 19 17:42:47 2019 +0100
     2.2 +++ b/pEpObjCAdapterFramework/PEPSync.h	Wed Nov 20 09:10:05 2019 +0100
     2.3 @@ -18,9 +18,6 @@
     2.4   */
     2.5  @interface PEPSync : NSObject
     2.6  
     2.7 -/// Is the sync loop running?
     2.8 -@property (nonatomic) BOOL isRunning;
     2.9 -
    2.10  @property (nonatomic, nullable, weak) id<PEPSendMessageDelegate> sendMessageDelegate;
    2.11  @property (nonatomic, nullable, weak) id<PEPNotifyHandshakeDelegate> notifyHandshakeDelegate;
    2.12  
     3.1 --- a/pEpObjCTests/PEPSessionTest.m	Tue Nov 19 17:42:47 2019 +0100
     3.2 +++ b/pEpObjCTests/PEPSessionTest.m	Wed Nov 20 09:10:05 2019 +0100
     3.3 @@ -1549,12 +1549,6 @@
     3.4                   notifyHandshakeDelegate:self.notifyHandshakeDelegate];
     3.5      [self.sync startup];
     3.6  
     3.7 -    XCTKVOExpectation *expHaveStartedSync = [[XCTKVOExpectation alloc]
     3.8 -                                             initWithKeyPath:@"isRunning"
     3.9 -                                             object:self.sync
    3.10 -                                             expectedValue: [NSNumber numberWithBool:YES]];
    3.11 -    [self waitForExpectations:@[expHaveStartedSync] timeout:PEPTestInternalSyncTimeout];
    3.12 -
    3.13      XCTAssertTrue([[PEPSession new] isKeySyncEnabled]);
    3.14  }
    3.15