Sat, 17 Feb 2018 21:23:58 +0100 Krista Bennett ENGINE-382 - fixing update bug
Fri, 16 Feb 2018 18:55:19 +0100 Krista Bennett merge
Fri, 16 Feb 2018 18:53:44 +0100 Krista Bennett So, uh, it turns out argument order is important. Who knew? Fixed get_identity calls which would have impacted ratings when update_identity gets called without a user_id (which means it also impacts own_identities called without an own user id or .me set)
Fri, 16 Feb 2018 15:54:37 +0100 Dirk Zimmermann ENGINE-374 rm sqlite.* source for iOS
Fri, 16 Feb 2018 08:35:34 +0100 Krista Bennett merge
Fri, 16 Feb 2018 08:35:04 +0100 Krista Bennett ENGINE-382: changed alter table with non-constant default for timestamp to copy-insert-drop for version 8
Thu, 15 Feb 2018 08:34:37 +0100 Thomas OUT-403: Add pEp_string.c and pEp_string.h to pEpEngine.vcxproj
Thu, 15 Feb 2018 00:36:33 +0100 Krista Bennett Fix for ENGINE-356
Thu, 15 Feb 2018 00:15:05 +0100 Krista Bennett Added prioritisation of own ids and forgotten prioritisation of recent records, necessary for update_identity to work properly; message to self now gets green from outgoing_message_rating
Wed, 14 Feb 2018 18:49:09 +0100 Krista Bennett Other SQL fixes for, for example, constraint errors on person.main_key_id. This is like pulling your own teeth without novacaine...
Wed, 14 Feb 2018 16:02:08 +0100 Krista Bennett ENGINE-379 and probably other problems: was calling set_identity from within set_as_pep_user, which was called by get_trust, which is called from set_identity. So... yeah. Bad.
Tue, 13 Feb 2018 16:08:48 +0100 Krista Bennett Damnit, shut off trusted own key import again. Fixed.
Tue, 13 Feb 2018 10:24:12 +0100 Krista Bennett added temporary timing logs thomas_timing_tests
Tue, 13 Feb 2018 00:13:18 +0100 Krista Bennett ADD_TO_LOG and GOTO are now simply removed everywhere.
Mon, 12 Feb 2018 23:02:13 +0100 Krista Bennett ENGINE-360 and ENGINE-373 - double free fun action.
Mon, 12 Feb 2018 12:45:27 +0100 Krista Bennett Removing log_event errors - if it fails, it fails.
Mon, 12 Feb 2018 12:17:03 +0100 Krista Bennett Removing logging from the log_event function when logging fails
Mon, 12 Feb 2018 08:36:07 +0100 Roker fix 3 compiler warings at once. :-)
Mon, 12 Feb 2018 01:52:57 +0100 Krista Bennett ENGINE-360: Let's try again, shall we? Lots of fixes related to address-only identities.
Sun, 11 Feb 2018 18:31:35 +0100 Krista Bennett Argh, accidentally committed import key disable. Sorry.
Sun, 11 Feb 2018 17:02:19 +0100 Krista Bennett Fixed ENGINE-364 and some test bugs. Users now much be CERTAIN to call update_identity if they need the comm_type afte trust_personal_key (this is in accord with the API)
Fri, 09 Feb 2018 16:32:47 +0100 Krista Bennett ENGINE-360: I *think* this should take care of the no-username problem.
Fri, 09 Feb 2018 10:30:50 +0100 Krista Bennett unnecessary break in the middle of updating recipient lists for MIME_encrypt
Fri, 09 Feb 2018 09:03:11 +0100 Krista Bennett Added set_as_pep_user to set trust
Fri, 09 Feb 2018 08:14:27 +0100 Krista Bennett ENGINE-365: is_pep_user() is now exposed to the outside. See pep_engine.h documentation
Thu, 08 Feb 2018 20:05:10 +0100 Krista Bennett Removed Roker test that broke message_api_test.cc when run outside of the testing environment (this isn't a case of avoiding a bug, but rather the case would fail because the keys tested are actual keys which some of us have present in our real keyrings, and test presumes we do not.
Wed, 07 Feb 2018 19:08:11 +0100 Krista Bennett Argh... if true...
Wed, 07 Feb 2018 18:46:29 +0100 Krista Bennett Removed inadverent commit of sqlite3 header include
Wed, 07 Feb 2018 16:53:36 +0100 Krista Bennett Turned automatic first-time import of ultimately trusted keys back on
Wed, 07 Feb 2018 16:47:05 +0100 Krista Bennett Closing branch (not "brain", as I originally wrote...) ENGINE-250
Wed, 07 Feb 2018 16:46:21 +0100 Krista Bennett Merged in ENGINE-250 - foreign keys are now on, as they should have been forever.
Wed, 07 Feb 2018 16:42:56 +0100 Krista Bennett ENGINE-250: foreign keys are now on and tests pass. Be aware that with the amount of time we may have been running with them off, there may be other execution paths that cause trouble. File bugs against any DB errors. ENGINE-250
Wed, 07 Feb 2018 16:16:40 +0100 Krista Bennett Probably own identity issues. ENGINE-250
Wed, 07 Feb 2018 16:05:04 +0100 Krista Bennett ENGINE-250: address fixes and more; lower() still does something really goofy on the FIRST run with make test, but only then, and even if all databases and keyrings are removed, case_and_dot_address_test still passes for every time after until the next time you make clean *with the whole engine* and rebuild. BIZARRE. ENGINE-250
Wed, 07 Feb 2018 10:22:23 +0100 Krista Bennett ENGINE-250: Pretty sure the current bugs are now actual bugs and not sql-related. But will check. insert-or-replace for identity-based set functions is now replaced with a slightly convoluted callback mechanism which does a check for existence and then updates or inserts appropriately, with optional transaction guards (to be set to false if they're called in what's already a transaction, e.g. set_identity) ENGINE-250
Wed, 07 Feb 2018 09:23:51 +0100 Krista Bennett ENGINE-250: Marginally working, but changes() doesn't seem to be a sufficient way of differentiating between update and insert. COuld be my bug though. Some tests still fail, but we need a commit here. ENGINE-250
Tue, 06 Feb 2018 18:48:45 +0100 Krista Bennett ENGINE-250: fixed some things, am screaming at others. Have overcome the 'insert or update' issue at least, probably. ENGINE-250
Mon, 05 Feb 2018 10:58:03 +0100 Krista Bennett Intermittent commit ENGINE-250
Sun, 04 Feb 2018 15:26:28 +0100 Krista Bennett Merged in fixes for ENGINE-352, ENGINE-345, a bunch of trust/mistrust issues, and general mayhem.
Sun, 04 Feb 2018 03:53:54 +0100 Krista Bennett closing branch mistrust_fixes
Sun, 04 Feb 2018 03:53:41 +0100 Krista Bennett closing branch ENGINE-352
Sun, 04 Feb 2018 03:52:27 +0100 Krista Bennett Merged in ENGINE-352 database_change_branch
Sun, 04 Feb 2018 03:38:28 +0100 Krista Bennett Merged the mistrust fixes into branch for merging database changes before adding to default database_change_branch
Sun, 04 Feb 2018 03:36:08 +0100 Krista Bennett A whole horde of trust fixes (mistrust list added, tests fixed, and sneaky null string in elect key removed) mistrust_fixes
Sun, 04 Feb 2018 02:05:53 +0100 Krista Bennett ENGINE-352: added is_pep_user exception in encrypt_message ENGINE-352
Fri, 02 Feb 2018 17:15:33 +0100 Krista Bennett ENGINE-352: we now update the right comm_type in the right place. ENGINE-352
Fri, 02 Feb 2018 11:03:20 +0100 Krista Bennett ENGINE-352: put in the mechanism to attach an is_pep mechanism for the user; tacking pEp messages is complicated, however, as it seems we've also always fouled up when we checked on that (we don't check what key it's encrypted with before we declare whatever key gets retrieved by update_identity is the same, and then set the comm_type on that, which could be the wrong key.) So that's the next fix. ENGINE-352
Thu, 01 Feb 2018 13:57:04 +0100 Krista Bennett shelving mistrust investigation and fixes to fry bigger fish mistrust_fixes
Mon, 29 Jan 2018 16:52:54 +0100 Krista Bennett ENGINE-345: fix to outgoing_message_rating - set to PEP_rating_unencrypted instead of unknown
Mon, 29 Jan 2018 12:44:56 +0100 Krista Bennett Ok, now really closing this branch. For real. ENGINE-329
Mon, 29 Jan 2018 12:40:43 +0100 Krista Bennett merge
Mon, 29 Jan 2018 12:40:04 +0100 Krista Bennett Properly merged in ENGINE-329
Mon, 29 Jan 2018 12:36:02 +0100 Krista Bennett Fixing bad merges still. ENGINE-329
Mon, 29 Jan 2018 12:15:51 +0100 Krista Bennett Urgh. Fixing bad merge (???)
Fri, 26 Jan 2018 16:37:27 +0100 Krista Bennett Closed branch ENGINE-329
Fri, 26 Jan 2018 16:32:08 +0100 Krista Bennett Merged in ENGINE-329
Fri, 26 Jan 2018 16:30:39 +0100 Krista Bennett ENGINE-329: gpg implementation of first-time import of ultimately trusted keys is in. Apparently, netpgp bluffs trust completely, so a stub is in here for them instead. Too bad :( ENGINE-329
Fri, 26 Jan 2018 10:33:37 +0100 Krista Bennett intermittent commit ENGINE-329
Thu, 25 Jan 2018 15:50:21 +0100 Krista Bennett Merged in default ENGINE-329
Thu, 25 Jan 2018 15:13:28 +0100 Krista Bennett Closed branch ENGINE-289