Wed, 07 Feb 2018 16:47:05 +0100Closing branch (not "brain", as I originally wrote...) ENGINE-250
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 16:47:05 +0100] rev 2485
Closing branch (not "brain", as I originally wrote...)

Wed, 07 Feb 2018 16:46:21 +0100Merged in ENGINE-250 - foreign keys are now on, as they should have been forever.
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 16:46:21 +0100] rev 2484
Merged in ENGINE-250 - foreign keys are now on, as they should have been forever.

Wed, 07 Feb 2018 16:42:56 +0100ENGINE-250: foreign keys are now on and tests pass. Be aware that with the amount of time we may have been running with them off, there may be other execution paths that cause trouble. File bugs against any DB errors. ENGINE-250
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 16:42:56 +0100] rev 2483
ENGINE-250: foreign keys are now on and tests pass. Be aware that with the amount of time we may have been running with them off, there may be other execution paths that cause trouble. File bugs against any DB errors.

Wed, 07 Feb 2018 16:16:40 +0100Probably own identity issues. ENGINE-250
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 16:16:40 +0100] rev 2482
Probably own identity issues.

Wed, 07 Feb 2018 16:05:04 +0100ENGINE-250: address fixes and more; lower() still does something really goofy on the FIRST run with make test, but only then, and even if all databases and keyrings are removed, case_and_dot_address_test still passes for every time after until the next time you make clean *with the whole engine* and rebuild. BIZARRE. ENGINE-250
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 16:05:04 +0100] rev 2481
ENGINE-250: address fixes and more; lower() still does something really goofy on the FIRST run with make test, but only then, and even if all databases and keyrings are removed, case_and_dot_address_test still passes for every time after until the next time you make clean *with the whole engine* and rebuild. BIZARRE.

Wed, 07 Feb 2018 10:22:23 +0100ENGINE-250: Pretty sure the current bugs are now actual bugs and not sql-related. But will check. insert-or-replace for identity-based set functions is now replaced with a slightly convoluted callback mechanism which does a check for existence and then updates or inserts appropriately, with optional transaction guards (to be set to false if they're called in what's already a transaction, e.g. set_identity) ENGINE-250
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 10:22:23 +0100] rev 2480
ENGINE-250: Pretty sure the current bugs are now actual bugs and not sql-related. But will check. insert-or-replace for identity-based set functions is now replaced with a slightly convoluted callback mechanism which does a check for existence and then updates or inserts appropriately, with optional transaction guards (to be set to false if they're called in what's already a transaction, e.g. set_identity)

Wed, 07 Feb 2018 09:23:51 +0100ENGINE-250: Marginally working, but changes() doesn't seem to be a sufficient way of differentiating between update and insert. COuld be my bug though. Some tests still fail, but we need a commit here. ENGINE-250
Krista Bennett <krista@pep-project.org> [Wed, 07 Feb 2018 09:23:51 +0100] rev 2479
ENGINE-250: Marginally working, but changes() doesn't seem to be a sufficient way of differentiating between update and insert. COuld be my bug though. Some tests still fail, but we need a commit here.

Tue, 06 Feb 2018 18:48:45 +0100ENGINE-250: fixed some things, am screaming at others. Have overcome the 'insert or update' issue at least, probably. ENGINE-250
Krista Bennett <krista@pep-project.org> [Tue, 06 Feb 2018 18:48:45 +0100] rev 2478
ENGINE-250: fixed some things, am screaming at others. Have overcome the 'insert or update' issue at least, probably.

Mon, 05 Feb 2018 10:58:03 +0100Intermittent commit ENGINE-250
Krista Bennett <krista@pep-project.org> [Mon, 05 Feb 2018 10:58:03 +0100] rev 2477
Intermittent commit

Sun, 04 Feb 2018 15:26:28 +0100Merged in fixes for ENGINE-352, ENGINE-345, a bunch of trust/mistrust issues, and general mayhem.
Krista Bennett <krista@pep-project.org> [Sun, 04 Feb 2018 15:26:28 +0100] rev 2476
Merged in fixes for ENGINE-352, ENGINE-345, a bunch of trust/mistrust issues, and general mayhem.