Fri, 09 Mar 2018 07:35:38 +0100 merge
Fri, 09 Mar 2018 07:14:55 +0100 reconcile input identities to decrypt_message (especially user_ids) with those on the outer message
Fri, 09 Mar 2018 03:18:15 +0100 Some ENGINE-400-related fun, but we're not there yet.
Fri, 09 Mar 2018 03:18:15 +0100 Some ENGINE-400-related fun, but we're not there yet.
Fri, 09 Mar 2018 07:14:55 +0100 reconcile input identities to decrypt_message (especially user_ids) with those on the outer message
Wed, 28 Feb 2018 15:59:16 +0100 ENGINE-347: fixed illegal shift in message ID production
Wed, 28 Feb 2018 14:54:30 +0100 ENGINE-294: blacklisting is now only checked in identity_rating, outgoing_message_rating and encrypt_message, and then only for OpenPGP comm_types.
Wed, 28 Feb 2018 12:24:48 +0100 ENGINE-294: basic code is in to remove blacklisting from anything but encrypt_message and outgoing_message_rating, but tests need to be extended, and have to switch to ENGINE-397 and fix that to keep the keyring clean.
Wed, 28 Feb 2018 10:05:56 +0100 ENGINE-396: reserve bailing from re_evaluate to DB failure cases
Sat, 24 Feb 2018 16:40:44 +0100 ENGINE-387: do not consider username in first update_identity from MIME_encrypt due to enigmail address-only policy (will still be patched later)
Thu, 22 Feb 2018 17:18:24 +0100 ENGINE-390: fixed deprecated _decrypt_in_pieces; we need to talk about how much backward compatibility we'll maintain.
Wed, 21 Feb 2018 17:05:56 +0100 ENGINE-362: decorate with pEp version in encrypt_message_to_self for M2.0 decrypt
Wed, 21 Feb 2018 15:47:21 +0100 ENGINE-362: possible fix for empty opt_fields which may be causing the problem
Wed, 21 Feb 2018 09:57:53 +0100 ENGINE-389: type confusion - corrected rating_unencrypted to ct_no_encryption for determining max comm type.
Tue, 20 Feb 2018 12:35:30 +0100 ENGINE-386: should now decorate all unencrypted messages, no matter what.
Mon, 19 Feb 2018 13:59:49 +0100 Remains of ENGINE-345
Mon, 19 Feb 2018 09:08:03 +0100 ENGINE-345 - return PEP_rating_undefined when there is no recipient (let me know if you are getting it for other reasons; if all identities are somehow broken or the DB chokes, this can happen here as well
Tue, 13 Feb 2018 10:24:12 +0100 added temporary timing logs
Tue, 13 Feb 2018 00:13:18 +0100 ADD_TO_LOG and GOTO are now simply removed everywhere.
Mon, 12 Feb 2018 01:52:57 +0100 ENGINE-360: Let's try again, shall we? Lots of fixes related to address-only identities.
Fri, 09 Feb 2018 16:32:47 +0100 ENGINE-360: I *think* this should take care of the no-username problem.
Fri, 09 Feb 2018 10:30:50 +0100 unnecessary break in the middle of updating recipient lists for MIME_encrypt
Tue, 06 Feb 2018 18:48:45 +0100 ENGINE-250: fixed some things, am screaming at others. Have overcome the 'insert or update' issue at least, probably.
Mon, 05 Feb 2018 10:58:03 +0100 Intermittent commit
Sun, 04 Feb 2018 03:52:27 +0100 Merged in ENGINE-352
Sun, 04 Feb 2018 02:05:53 +0100 ENGINE-352: added is_pep_user exception in encrypt_message
Fri, 02 Feb 2018 17:15:33 +0100 ENGINE-352: we now update the right comm_type in the right place.
Thu, 01 Feb 2018 13:57:04 +0100 shelving mistrust investigation and fixes to fry bigger fish
Mon, 29 Jan 2018 16:52:54 +0100 ENGINE-345: fix to outgoing_message_rating - set to PEP_rating_unencrypted instead of unknown
Mon, 29 Jan 2018 12:36:02 +0100 Fixing bad merges still.
Mon, 29 Jan 2018 12:15:51 +0100 Urgh. Fixing bad merge (???)
Thu, 25 Jan 2018 12:24:56 +0100 ENGINE-335: handle retvals of updated keyless To identities appropriately
Wed, 24 Jan 2018 11:57:10 +0100 ENGINE-340: removed extra mistrust check - problem was actually a missing set in key_mistrust when there is not yet a set identity
Wed, 24 Jan 2018 10:54:04 +0100 ENGINE-340: fixed persistence issues caused by removing mistrusted keys as defaults in ENGINE-332 branch
Fri, 19 Jan 2018 15:15:41 +0100 within message_api.c, we always get the identities from the engine or an adapter, so we do myself vs. update_identity checks where appropriate
Fri, 19 Jan 2018 14:18:19 +0100 ARGH. NOW have fixed update_identity/myself call in outgoing message rating. Put in fix backward.
Fri, 19 Jan 2018 14:12:02 +0100 fixed update_identity call that could be called on a myself value in outgoing_message_rating
Tue, 16 Jan 2018 23:31:06 +0100 ENGINE-289: oops - combined merging in of default and adding pref for update_identity to select an own_identity from the DB when it has a choice and the input only has an address.
Tue, 16 Jan 2018 14:14:01 +0100 ENGINE-289: passing tests again. Still need to revisit the myself() in MIME_encrypt (it's been pushed into encrypt's myself with a user_id check), ensure priority of own idents over other idents in update_identity in certain circumstances (when we don't know a priori that it's an own identity), and general post-apocalyptic cleanup, plus some specific tests (most cases are exercised in the test suite, but surely not all).
Tue, 16 Jan 2018 01:45:58 +0100 ENGINE-289: the nightmare continues... fixed out behaviour in MIME_encrypt/decrypt (we needed to treat identities more as if we were the app in the decoded message), fixed the ct return in find_single_keys, more debugging of my own mess in refactoring and rewriting, and, oh yeah, an expired test keypair that made me freak out when my code did exactly what it was SUPPOSED to to because I didn't know it was expired.
Mon, 15 Jan 2018 17:12:49 +0100 ENGINE-289: myself() changes and related fallout. Committing to merge in default.
Mon, 15 Jan 2018 17:07:05 +0100 merge "default" into "ENGINE-320" and solved one merge conflict. :-)
Wed, 10 Jan 2018 16:19:07 +0100 ENGINE-289: All old tests now pass!
Mon, 08 Jan 2018 12:19:34 +0100 Merged in default AND fixed SQL problem (oops)
Sat, 30 Dec 2017 17:01:07 +0100 BCC extra rules only apply when encryption will take place
Sat, 30 Dec 2017 16:54:37 +0100 ENGINE-323 fixed
Sat, 30 Dec 2017 16:06:57 +0100 settings enc_format to PEP_enc_none now legal in encrypt_message()
Sat, 30 Dec 2017 15:41:38 +0100 PEP_enc_none allowed
Sat, 30 Dec 2017 14:45:55 +0100 error second grade
Sat, 23 Dec 2017 18:41:02 +0100 PGP/MIME encoding will go wrong otherwise
Mon, 18 Dec 2017 23:10:29 +0100 ENGINE-289: So it compiles, but there are sql errors before we get very far. Too tired to debug tonight.
Sun, 17 Dec 2017 18:21:08 +0100 merged in default
Sat, 16 Dec 2017 20:42:03 +0100 ENGINE-314: solved overencoding problem for pgp attachments; mechanism is in place to add any known ascii (by definition) mime-type, so should this appear again, we know where to fix it.
Thu, 14 Dec 2017 17:05:28 +0100 ENGINE-320: done. Change is as follows: All calls to new_bloblist keep the ownership of the blob with the caller; this blob is assigned to bloblist->value_ref, which free_bloblist (and the engine) treat as read_only. Whenever the ENGINE allocates a blob (including via any calls to bloblist_dup()), it uses an internal bloblist creation function which assigns that reference to bloblist->value, which will be deallocated by free_bloblist if present. CALLERS MUST KEEP REFERENCES TO ANY BLOBS PASSED IN, as the engine is allowed to delete the bloblist node for various reason (key removal, etc), even if it cannot touch the blob.
Thu, 14 Dec 2017 08:51:26 +0100 ENGINE-320: Phase one, alpha renaming complete.
Tue, 05 Dec 2017 10:00:48 +0100 ENGINE-293: compiling again. Need to fix test cases and see what I have wrought with the PEP_OWN_USERID removals. After that, next step is to really fix myself()
Wed, 22 Nov 2017 10:44:14 +0100 merged in default
Wed, 22 Nov 2017 10:28:40 +0100 ENGINE-316: fixed bad status return when decrypted message couldn't be verified
Wed, 22 Nov 2017 09:43:14 +0100 Shelving to check for changes. Next step here is to continue dealing with PEP_OWN_USERID as the only marker all over the DB
Tue, 21 Nov 2017 18:10:20 +0100 moved private key import out from 'decrypted-but-not-yet-verified' block.