src/keymanagement.c
Sat, 24 Feb 2018 21:19:10 +0100 MSVC wants init
Sat, 24 Feb 2018 20:21:55 +0100 merging
Sat, 24 Feb 2018 20:21:37 +0100 slightly reworking initial PGP key import in case of GnuPG
Sat, 24 Feb 2018 19:12:11 +0100 ENGINE-394: Add case in update_identity for identities which have an address and username, where retrieved user_id is TOFU and usernames don't match
Sat, 24 Feb 2018 19:12:11 +0100 ENGINE-394: Add case in update_identity for identities which have an address and username, where retrieved user_id is TOFU and usernames don't match
Sat, 24 Feb 2018 16:51:38 +0100 SEMANTIC CHANGE in myself(): .fpr is never used; to set fpr now use set_own_key()
Mon, 19 Feb 2018 15:34:10 +0100 ENGINE-DIRKSAIDSO: strdup(NULL) is bad, mmmkay?
Mon, 19 Feb 2018 12:03:30 +0100 ENGINE-354: fixed bad call to is_pep_user
Mon, 19 Feb 2018 11:54:23 +0100 Fixes for a couple of return values adjusted in recent commits; ENGINE-354: checks now in update_identity against the user pep status field.
Fri, 16 Feb 2018 18:53:44 +0100 So, uh, it turns out argument order is important. Who knew? Fixed get_identity calls which would have impacted ratings when update_identity gets called without a user_id (which means it also impacts own_identities called without an own user id or .me set)
Thu, 15 Feb 2018 00:36:33 +0100 Fix for ENGINE-356
Thu, 15 Feb 2018 00:15:05 +0100 Added prioritisation of own ids and forgotten prioritisation of recent records, necessary for update_identity to work properly; message to self now gets green from outgoing_message_rating
Wed, 14 Feb 2018 16:02:08 +0100 ENGINE-379 and probably other problems: was calling set_identity from within set_as_pep_user, which was called by get_trust, which is called from set_identity. So... yeah. Bad.
Tue, 13 Feb 2018 00:13:18 +0100 ADD_TO_LOG and GOTO are now simply removed everywhere.
Mon, 12 Feb 2018 23:02:13 +0100 ENGINE-360 and ENGINE-373 - double free fun action.
Mon, 12 Feb 2018 08:36:07 +0100 fix 3 compiler warings at once. :-)
Mon, 12 Feb 2018 01:52:57 +0100 ENGINE-360: Let's try again, shall we? Lots of fixes related to address-only identities.
Sun, 11 Feb 2018 17:02:19 +0100 Fixed ENGINE-364 and some test bugs. Users now much be CERTAIN to call update_identity if they need the comm_type afte trust_personal_key (this is in accord with the API)
Fri, 09 Feb 2018 16:32:47 +0100 ENGINE-360: I *think* this should take care of the no-username problem.
Wed, 07 Feb 2018 16:42:56 +0100 ENGINE-250: foreign keys are now on and tests pass. Be aware that with the amount of time we may have been running with them off, there may be other execution paths that cause trouble. File bugs against any DB errors.
Tue, 06 Feb 2018 18:48:45 +0100 ENGINE-250: fixed some things, am screaming at others. Have overcome the 'insert or update' issue at least, probably.
Mon, 05 Feb 2018 10:58:03 +0100 Intermittent commit
Sun, 04 Feb 2018 03:36:08 +0100 A whole horde of trust fixes (mistrust list added, tests fixed, and sneaky null string in elect key removed)
Thu, 01 Feb 2018 13:57:04 +0100 shelving mistrust investigation and fixes to fry bigger fish
Mon, 29 Jan 2018 16:52:54 +0100 ENGINE-345: fix to outgoing_message_rating - set to PEP_rating_unencrypted instead of unknown
Mon, 29 Jan 2018 12:36:02 +0100 Fixing bad merges still.
Mon, 29 Jan 2018 12:15:51 +0100 Urgh. Fixing bad merge (???)
Wed, 24 Jan 2018 18:22:36 +0100 ENGINE-332: a few tests and some bug fixes
Wed, 24 Jan 2018 10:54:04 +0100 ENGINE-340: fixed persistence issues caused by removing mistrusted keys as defaults in ENGINE-332 branch
Mon, 22 Jan 2018 17:40:44 +0100 ENGINE-332: key_reset_trust and key mistrust fixed
Mon, 22 Jan 2018 11:11:38 +0100 ENGINE-332: rewrite complete, but needs checking and testing.
Fri, 19 Jan 2018 16:36:27 +0100 Fixed update_identity vs. myself calls in keymanagement, plus what would have been inconsistent behaviour in trust_personal_key for quite sometime (update_identity fprs have been write_only for some time, so calling it within the function without checking meant the input FPR was effectively ignored.
Thu, 18 Jan 2018 16:45:01 +0100 EMPTYSTR fixes
Thu, 18 Jan 2018 12:03:12 +0100 Fixed empty string issues
Thu, 18 Jan 2018 00:38:42 +0100 ENGINE_289: further status propagation fixes
Thu, 18 Jan 2018 00:03:23 +0100 ENGINE-289: added propagation of initial key retrieval failure (when != PEP_KEY_NOT_FOUND) and no good key is found - when revoked/expired, PEP_KEY_UNSUITABLE + PEP_ct_key_{expired,revoked} returned
Wed, 17 Jan 2018 22:49:46 +0100 ENGINE-289: tested adn tests up to key election - that comes next. Minor bug fixes in update_identity
Wed, 17 Jan 2018 12:39:10 +0100 ENGINE-289: changed initialise_own_identities to deal with default user_id aliases
Wed, 17 Jan 2018 12:23:44 +0100 ENGINE-289: added tests for myself() default user_id aliases, fixed consts in signature, fixed blacklist test issue
Wed, 17 Jan 2018 01:18:18 +0100 ENGINE-289: added default user_id aliases to myself()
Tue, 16 Jan 2018 23:31:06 +0100 ENGINE-289: oops - combined merging in of default and adding pref for update_identity to select an own_identity from the DB when it has a choice and the input only has an address.
Tue, 16 Jan 2018 14:14:01 +0100 ENGINE-289: passing tests again. Still need to revisit the myself() in MIME_encrypt (it's been pushed into encrypt's myself with a user_id check), ensure priority of own idents over other idents in update_identity in certain circumstances (when we don't know a priori that it's an own identity), and general post-apocalyptic cleanup, plus some specific tests (most cases are exercised in the test suite, but surely not all).
Tue, 16 Jan 2018 01:45:58 +0100 ENGINE-289: the nightmare continues... fixed out behaviour in MIME_encrypt/decrypt (we needed to treat identities more as if we were the app in the decoded message), fixed the ct return in find_single_keys, more debugging of my own mess in refactoring and rewriting, and, oh yeah, an expired test keypair that made me freak out when my code did exactly what it was SUPPOSED to to because I didn't know it was expired.
Mon, 15 Jan 2018 17:12:49 +0100 ENGINE-289: myself() changes and related fallout. Committing to merge in default.
Thu, 11 Jan 2018 22:47:13 +0100 ENGINE-289: Per Volker, there actually CAN be multiple own IDs because different apps may use their own. Committing before I go to explore that hot mess (and start crying).
Wed, 10 Jan 2018 16:19:07 +0100 ENGINE-289: All old tests now pass!
Wed, 10 Jan 2018 09:19:44 +0100 ENGINE-289: empty fpr on identity input now ok. removed superfluous (and incorrect) check.
Wed, 10 Jan 2018 08:18:52 +0100 ENGINE-289: fixed bad status carryover
Tue, 09 Jan 2018 13:27:56 +0100 ENGINE-289: updated test and code to deal with trust correctly on elected, not-in-DB keys after revocation
Mon, 18 Dec 2017 23:10:29 +0100 ENGINE-289: So it compiles, but there are sql errors before we get very far. Too tired to debug tonight.
Mon, 18 Dec 2017 23:00:56 +0100 ENGINE-289: intermittent commit - almost compiling cleanly (yes, it's that far away from tested. It's complicated.
Mon, 18 Dec 2017 21:31:22 +0100 ENGINE-289: intermittent commit
Mon, 18 Dec 2017 13:27:42 +0100 ENGINE-289: Intermittent commit - need to refactor some logic big-time.
Sat, 16 Dec 2017 15:35:38 +0100 ENGINE_289: intermittent commit - shelving changes
Fri, 15 Dec 2017 12:49:03 +0100 ENGINE-320: intermittent commit
Wed, 13 Dec 2017 11:42:23 +0100 ENGINE-289: shelving to work on another bug
Sat, 09 Dec 2017 13:04:40 +0100 ENGINE-293: initialise_own_identities (cheap myself() only keygen/retrieval) + additional internal fprless get_identity function added so that temporary identities w/o fpr can be retrieved
Tue, 05 Dec 2017 16:35:23 +0100 ENGINE-293: Compiles and runs SOME tests. SQL and myself() fixes.
Tue, 05 Dec 2017 10:00:48 +0100 ENGINE-293: compiling again. Need to fix test cases and see what I have wrought with the PEP_OWN_USERID removals. After that, next step is to really fix myself()
Mon, 04 Dec 2017 18:23:14 +0100 ENGINE-293: Intermittent commit. Probably not compiling yet, but PEP_OWN_USERID is out from src where it needs to be.